Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pcied] Fix pcied failure to load due to 'pcied NameError: name 'self' is not defined' #198

Merged
merged 1 commit into from
Jul 13, 2021

Conversation

DavidZagury
Copy link
Contributor

@DavidZagury DavidZagury commented Jul 4, 2021

Description

Fix sonic-net/sonic-buildimage#7993

  • Fixes wrong log line when Pcie module does not exists that causes the pcied daemon to enter FATAL state.
  • Change log level of line "Failed to load platform Pcie module" to notice since this is not an error flow, this is part of the normal loading flow we expect when a vendor didn't supply a Pcie class.

Motivation and Context

How Has This Been Tested?

Load image, check pcied daemon status.

Additional Information (Optional)

@DavidZagury DavidZagury marked this pull request as draft July 4, 2021 12:09
@DavidZagury DavidZagury changed the title [pcied] Fix pcied failure to load due to 'pcied NameError: name 'self… [pcied] Fix pcied failure to load due to 'pcied NameError: name 'self' is not defined' Jul 5, 2021
@DavidZagury DavidZagury marked this pull request as ready for review July 5, 2021 16:42
@BasimShalata
Copy link

@sujinmkang can you please review.

@liat-grozovik liat-grozovik requested a review from sujinmkang July 6, 2021 10:12
Copy link
Contributor

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@lguohan lguohan merged commit 66e7817 into sonic-net:master Jul 13, 2021
qiluo-msft pushed a commit to sonic-net/sonic-buildimage that referenced this pull request Jul 15, 2021
To include:
> 66e7817 2021-07-13 [pcied] Fix pcied failure to load due to 'pcied NameError: name 'self' is not defined' (sonic-net/sonic-platform-daemons#198) 
> 3df6757 2021-07-08 [ci] fix result color bar in the code coverage report (sonic-net/sonic-platform-daemons#196)
judyjoseph pushed a commit to sonic-net/sonic-buildimage that referenced this pull request Aug 7, 2021
To include:
> 66e7817 2021-07-13 [pcied] Fix pcied failure to load due to 'pcied NameError: name 'self' is not defined' (sonic-net/sonic-platform-daemons#198) 
> 3df6757 2021-07-08 [ci] fix result color bar in the code coverage report (sonic-net/sonic-platform-daemons#196)
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
To include:
> 66e7817 2021-07-13 [pcied] Fix pcied failure to load due to 'pcied NameError: name 'self' is not defined' (sonic-net/sonic-platform-daemons#198) 
> 3df6757 2021-07-08 [ci] fix result color bar in the code coverage report (sonic-net/sonic-platform-daemons#196)
vdahiya12 pushed a commit to vdahiya12/sonic-platform-daemons that referenced this pull request Apr 4, 2022
…t#198)

sonic-config-engine now depends on sonic-yang-mgmt and sonic-yang-models, so we now need to install them as part of continuous integration to get the CI working again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pcied] daemon is in FATAL state when system starts
4 participants